fix usWinDescent

Changed files (4)

• modified libbirdfont/DrawingTools.vala
• modified libbirdfont/MainWindow.vala
• modified libbirdfont/OpenFontFormat/HheaTable.vala
• modified libbirdfont/OpenFontFormat/Os2Table.vala

Diff

diff --git a/libbirdfont/DrawingTools.vala b/libbirdfont/DrawingTools.valaindex 63c620c..2187dd0 100644--- a/libbirdfont/DrawingTools.vala+++ b/libbirdfont/DrawingTools.vala@@ -237,7 +237,7 @@ public class DrawingTools : ToolCollection  {  		Tool custom_character_set = new Tool ("custom_character_set", t_("Show default characters set"), 'r', CTRL); 		custom_character_set.select_action.connect ((self) => {-			MainWindow.get_tab_bar ().add_unique_tab (new OverView (), 100, false);+			MainWindow.get_tab_bar ().add_unique_tab (new OverView ()); 			OverView o = MainWindow.get_overview (); 			GlyphRange gr = new GlyphRange (); @@ -253,7 +253,7 @@ public class DrawingTools : ToolCollection  {  		Tool avalilable_characters = new Tool ("available_characters", t_("Show all characters in the font"), 'd', CTRL); 		avalilable_characters.select_action.connect ((self) => {-			MainWindow.get_tab_bar ().add_unique_tab (new OverView (), 100, false);+			MainWindow.get_tab_bar ().add_unique_tab (new OverView ()); 			OverView o = MainWindow.get_overview (); 			 			if (!BirdFont.get_current_font ().initialised) {diff --git a/libbirdfont/MainWindow.vala b/libbirdfont/MainWindow.valaindex 7c654fa..416d6e9 100644--- a/libbirdfont/MainWindow.vala+++ b/libbirdfont/MainWindow.vala@@ -63,7 +63,7 @@ public class MainWindow { 		if (! (t is MoveTool || t is ResizeTool)) {
 			Toolbox.select_tool_by_name ("move");
 		}
-		
+
 		get_current_glyph ().select_all_paths ();
 	}
 
diff --git a/libbirdfont/OpenFontFormat/HheaTable.vala b/libbirdfont/OpenFontFormat/HheaTable.valaindex c180f5f..1c557bd 100644--- a/libbirdfont/OpenFontFormat/HheaTable.vala+++ b/libbirdfont/OpenFontFormat/HheaTable.vala@@ -88,7 +88,7 @@ class HheaTable : Table { 		fd.add_fixed (version); // table version 		 		ascender = glyf_table.ymax;-		descender = glyf_table.ymin; // FIXME: look up, should it be -descender?+		descender = glyf_table.ymin; // FIXME: look up, should it be -descender or descender? 		 		fd.add_16 (ascender); // Ascender 		fd.add_16 (descender); // Descenderdiff --git a/libbirdfont/OpenFontFormat/Os2Table.vala b/libbirdfont/OpenFontFormat/Os2Table.valaindex ab7e91a..f379fa6 100644--- a/libbirdfont/OpenFontFormat/Os2Table.vala+++ b/libbirdfont/OpenFontFormat/Os2Table.vala@@ -102,14 +102,14 @@ class Os2Table : Table { 		fd.add_u16 (glyf_table.get_last_char ()); // usLastCharIndex  		ascender = glyf_table.ymax;-		descender = -glyf_table.ymin;+		descender = glyf_table.ymin; 		 		fd.add_16 (ascender); // sTypoAscender 		fd.add_16 (descender); // sTypoDescender 		fd.add_16 (3); // sTypoLineGap  		fd.add_u16 (ascender); // usWinAscent-		fd.add_u16 (descender); // usWinDescent+		fd.add_u16 (-descender); // usWinDescent (unassigned, not like sTypoDescender)  		// FIXME: 		fd.add_u32 (0); // ulCodePageRange1 Bits 0-31@@ -122,7 +122,7 @@ class Os2Table : Table { 		fd.add_16 (0x0020); // usBreakChar also known as space 		 		// FIXME: calculate these values-		fd.add_16 (1); // usMaxContext+		fd.add_16 (2); // usMaxContext  		// padding 		fd.pad ();