Clone in a terminal:
Commit bd5c73d
Johan Mattsson - 2016-06-12T11:43:32+00:00
bd5c73d35c6b9afc20ed20314c51c41ed931c01fjohan.mattsson.m@gmail.com

Close open glyphs when they are deleted in overview tab

Changed files (4)

Diff

diff --git a/libbirdfont/OverView.vala b/libbirdfont/OverView.valaindex 2e1a29e..4ccfba4 100644--- a/libbirdfont/OverView.vala+++ b/libbirdfont/OverView.vala@@ -1026,8 +1026,10 @@ public class OverView : FontDisplay { 		} 		store_undo_items (undo_item); -		foreach (GlyphCollection gc in selected_items) {-			font.delete_glyph (gc);+		foreach (GlyphCollection glyph_collection in selected_items) {+			font.delete_glyph (glyph_collection);+			string name = glyph_collection.get_name ();+			MainWindow.get_tab_bar ().close_background_tab_by_name (name); 		}  		update_item_list ();diff --git a/libbirdfont/OverViewItem.vala b/libbirdfont/OverViewItem.valaindex 8a32d1e..5764ea5 100644--- a/libbirdfont/OverViewItem.vala+++ b/libbirdfont/OverViewItem.vala@@ -455,7 +455,9 @@ public class OverViewItem : GLib.Object { 	} 	 	public void hide_menu () {-		version_menu.menu_visible = false;+		if (!is_null (version_menu)) {+			version_menu.menu_visible = false;+		} 	} 	 	private void draw_menu_icon (Context cc, bool selected) {diff --git a/libbirdfont/TabBar.vala b/libbirdfont/TabBar.valaindex 20c801b..fd542ad 100644--- a/libbirdfont/TabBar.vala+++ b/libbirdfont/TabBar.vala@@ -330,7 +330,9 @@ public class TabBar : GLib.Object { 				 		foreach (var t in tabs) { 			if (t.get_display ().get_name () == name) {-				return close_tab (i, background_tab);+				bool closed = close_tab (i, background_tab);+				redraw_tab_bar (0, 0, width, height);+				return closed; 			} 			 			i++;diff --git a/libbirdfont/VersionList.vala b/libbirdfont/VersionList.valaindex ba24d93..7c74267 100644--- a/libbirdfont/VersionList.vala+++ b/libbirdfont/VersionList.vala@@ -94,6 +94,8 @@ public class VersionList : GLib.Object { 		if (glyphs.size == 1) { 			over_view.store_undo_state (glyph_collection.copy ()); 			font.delete_glyph (glyph_collection);+			string name = glyph_collection.get_name ();+			MainWindow.get_tab_bar ().close_background_tab_by_name (name); 			return; 		} 		

Contact

Email: johan.mattsson.m@gmail.com
Mastodon: typo.social/@birdfont
GitHub: johanmattssonm
LinkedIn: johan-mattsson-2ab324112