Commit da4177f
complile with clang
Changed files (10)
modifiedlibbirdfont/BackgroundSelection.valamodifiedlibbirdfont/Glyph.valamodifiedlibbirdfont/GlyphBackgroundImage.valamodifiedlibbirdfont/GlyphRange.valamodifiedlibbirdfont/GlyphTable.valamodifiedlibbirdfont/MoveTool.valamodifiedlibbirdfont/OpenFontFormatWriter.valamodifiedlibbirdfont/Path.valamodifiedlibbirdfont/PenTool.valamodifiedlibbirdfont/TabBar.vala
Diff
@@ -33,7 +33,10 @@ class BackgroundSelection : FontDisplay { glyph = MainWindow.get_current_glyph (); i = Icons.get_icon ("add_background_image.png");- return_if_fail (i != null);+ if (i == null) {+ warning ("Could not find icon."); + }+ add_icon = (!) i; } @@ -171,7 +171,7 @@ public class Glyph : FontDisplay { } public Path? get_active_path () {- return_if_fail (!is_null(active_paths));+ return_val_if_fail (!is_null(active_paths), null); if (!is_null(active_paths.last ())) { return null;@@ -641,7 +641,7 @@ public class Glyph : FontDisplay { public EditPoint add_new_edit_point (int x, int y) { insert_edit_point (x, y); - return_if_fail (active_paths.length () > 0);+ return_val_if_fail (active_paths.length () > 0, new EditPoint ()); last_added_edit_point = active_paths.last ().data.get_last_point (); return (!) last_added_edit_point;@@ -729,13 +729,13 @@ public class Glyph : FontDisplay { public static double path_coordinate_x (double x) { Glyph g = MainWindow.get_current_glyph ();- return_if_fail (g.view_zoom != 0);+ return_val_if_fail (g.view_zoom != 0, 0); return x * ivz () - xc () + g.view_offset_x; } public static int reverse_path_coordinate_x (double x) { Glyph g = MainWindow.get_current_glyph ();- return_if_fail (g.view_zoom != 0);+ return_val_if_fail (g.view_zoom != 0, 0); return (int) Math.rint ((x - g.view_offset_x + xc ()) * g.view_zoom); } @@ -863,12 +863,12 @@ public class Glyph : FontDisplay { // FIXME: what about removeing this feature if (new_point_on_path != null) {- return_if_fail (active_paths.length () > 0);+ return_val_if_fail (active_paths.length () > 0, new EditPoint ()); Path p = new Path (); EditPoint e = (!) new_point_on_path; - return_if_fail (e.prev != null);+ return_val_if_fail (e.prev != null, new EditPoint ()); p.add_point (e); e.type = PointType.CUBIC;@@ -1018,7 +1018,7 @@ public class Glyph : FontDisplay { public Path? get_last_path () ensures (result != null) {- return_if_fail (path_list.length () > 0);+ return_val_if_fail (path_list.length () > 0, null); return path_list.last ().data; } @@ -564,13 +564,13 @@ public class GlyphBackgroundImage { len = 4 * w * h; pix_buff_t = img.get_data ();- return_if_fail (pix_buff_t != null);+ return_val_if_fail (pix_buff_t != null, null); pix_buff = pix_buff_t; contrast_img = new uchar[len]; pix_buff_t = contrast_img;- return_if_fail (pix_buff_t != null);+ return_val_if_fail (pix_buff_t != null, null); contrast += 70; contrast /= 71;@@ -183,7 +183,7 @@ public class GlyphRange { ranges.sort ((a, b) => { bool r = a.start > b.start; - return_if_fail (a.start != b.start);+ return_val_if_fail (a.start != b.start, 0); return (r) ? 1 : -1; });@@ -175,7 +175,7 @@ class GlyphTable : GLib.Object { int i1 = 0; int i2 = 0; - return_if_fail (bt != null);+ return_val_if_fail (bt != null, 0); int ca = an.char_count (); int cb = bn.char_count ();@@ -181,7 +181,7 @@ class MoveTool : Tool { double h; Path rp; - return_if_fail (!is_null (resized_path));+ return_val_if_fail (!is_null (resized_path), 0); rp = (!) resized_path; h = rp.xmax - rp.xmin; @@ -638,7 +638,7 @@ class LocaTable : Table { } public uint32 get_offset (uint32 i) { - return_if_fail (glyph_offsets != null); + return_val_if_fail (glyph_offsets != null, 0); if (size == 0) { warning ("No glyphs in loca table"); @@ -653,7 +653,7 @@ class LocaTable : Table { /** Returns true if glyph at index i is empty and have no body to parse. */ public bool is_empty (uint32 i) { - return_if_fail (glyph_offsets != null); + return_val_if_fail (glyph_offsets != null, true); if (size == 0) { warning ("No glyphs in loca table"); @@ -432,7 +432,7 @@ public class Path { } private double clockwise_sum () {- return_if_fail (points.length () >= 3);+ return_val_if_fail (points.length () >= 3, 0); double sum = 0; EditPoint prev = points.last ().data;@@ -883,8 +883,8 @@ public class PenTool : Tool { double min_right, min_left; double min; - return_if_fail (e.next != null);- return_if_fail (e.prev != null);+ return_val_if_fail (e.next != null, new EditPoint ());+ return_val_if_fail (e.prev != null, new EditPoint ()); // angle might be greater than 2 PI or less than 0 min_right = double.MAX;@@ -68,7 +68,9 @@ public class TabBar : GLib.Object { next_tab = (!) Icons.get_icon ("next_tab.png"); to_previous_tab = (!) Icons.get_icon ("previous_tab.png"); - return_if_fail (!is_null (next_tab));+ if (is_null (next_tab)) {+ warning ("Next tab is null");+ } } public void motion (double x, double y) {